Add isCustomElement flag for plugin tag configurations
#2786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables Vue compiler to recognize custom HTML elements
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2786 +/- ##
==========================================
+ Coverage 71.74% 71.76% +0.01%
==========================================
Files 134 134
Lines 7304 7316 +12
Branches 1612 1590 -22
==========================================
+ Hits 5240 5250 +10
- Misses 2018 2020 +2
Partials 46 46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gerteck
changed the title
customComponent flag for plugin tag configurationsisCustomElement flag for plugin tag configurations
…and update related logic and tests.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Overview of changes:
Adds support for plugins to configure specific tags as "custom elements" to be ignored by the Vue compiler. Enables Vue compiler to recognize custom HTML elements
Currently, if a plugin introduces Custom Elements (Web Components), Vue attempts to resolve them as Vue components during SSR, leading to warnings or errors. This PR allows plugins to opt-in to the
isCustomElementcompiler option viatagConfig.packages/core: UpdatedTagConfigstype inPlugin.tsto include thecustomComponentproperty.packages/core: UpdatedPageVueServerRenderer.tsto collect tags withcustomComponent: truefrom thePluginManagerand pass them to the VuecompilerOptions.isCustomElementcheck.docs: UpdatedwritingPlugins.mdto document the new configuration option.Anything you'd like to highlight/discuss:
Testing instructions:
customComponent: trueare ignored by the Vue component resolver and preserved as custom elements in the output.Proposed commit message: (wrap lines at 72 characters)
Add
isCustomElementflag for plugin tag configAdds support for plugins to configure specific tags as
custom elements to be ignored by the Vue compiler.
Checklist: ☑️
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major,r.Minor,r.Patch.Breaking change release note preparation (if applicable):